Re: SUM(int2)/SUM(int4) do not detect overflow of the int8 accumulator

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Andrei Lepikhov <lepihov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Subject: Re: SUM(int2)/SUM(int4) do not detect overflow of the int8 accumulator
Date: 2026-09-03 00:10:33
Message-ID: api6-XZG2tD_d1Jf@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 02, 2026 at 07:56:32PM -0400, Andres Freund wrote:
> FWIW, I think we should seriously consider making [almost] all the transition
> states internal. Having to support calling these functions in non-aggregate
> contexts adds complexity without any actual gain. We shouldn't need to check
> whether we are in an AggContext, whether the argument is toasted, whether
> there are NULL elements in the array, compute offsets into the array, etc.

+1.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2026-09-03 00:28:22 Stabilize 026_overwrite_contrecord test
Previous Message Andres Freund 2026-09-02 23:56:32 Re: SUM(int2)/SUM(int4) do not detect overflow of the int8 accumulator