Re: [PATCH] Test coverage for pg_clear_attribute_stats() null arguments

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: shihao zhong <zhong950419(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Test coverage for pg_clear_attribute_stats() null arguments
Date: 2026-09-02 07:25:29
Message-ID: apfPaSLkXEDu6hk5@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 01, 2026 at 09:32:02PM -0400, shihao zhong wrote:
> v2 attached. On top of the four null arguments it covers a missing
> schema, relation and column, a system column, and a sequence and a view
> for the relkind rejection.

The cases lacked a bit of consistency in terms of input values,
ordering and the comments, so fixed a bit of all that.. And done.

> For inherited I used a functional case rather than an error one: plant an
> inherited and a non-inherited row for one column, clear the inherited
> one, and check that the other survives.

That does the job. Thanks.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-09-02 07:37:04 Re: SUM(int2)/SUM(int4) do not detect overflow of the int8 accumulator
Previous Message Richard Guo 2026-09-02 06:52:17 Re: Unsafe qual pushdown through DISTINCT with simple CASE expressions