Re: Add starelid, attnum to pg_stats and leverage this in pg_dump

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
Date: 2026-08-31 05:33:40
Message-ID: apUSNL7IJIGYbNDl@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Aug 30, 2026 at 07:21:07PM -0500, Sami Imseih wrote:
>> Claude advises me that removing the redundant filter clause was a mistake.
>> See the attached patch.
>
> Yes, that was a miss. I did a quick confirmation of the execution plans
> with and without the patch and the change LGTM.

The extra time taken would really hurt when retrieving statistics.
There may be an argument in simply reverting 4b5ba0c4ca52, as one of
the reasons for it was to remove the qual you are re-adding, but I
cannot get excited about using two sets of catalog names for tablename
and spcname vs a single OID array approach in the long run.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Bertrand Drouvot 2026-08-31 05:06:36 Re: Offline data checksum changes can cause incorrect checksum state on standbys