| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Offline data checksum changes can cause incorrect checksum state on standbys |
| Date: | 2026-08-29 02:41:03 |
| Message-ID: | apJGv8fffeUfSkCL@bdtpg |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, Aug 28, 2026 at 11:04:28AM -0500, Zsolt Parragi wrote:
> > > I'll try to look into what adding the two
> > > patches together looks like, but it most likely combines their size,
> > > as they improve the current master code in different ways.
> >
> > Thanks!
>
> I looked into this,
Thanks!
> and I was right that if I add the pg_control
> changes to v4 it nearly doubles the size of the actual code changes
> from ~300 to ~550 lines, and fixes all the issues you reported
Yeah, that's what I expected, as v1 included those changes to handle these cases.
> while
> also keeping the existing suite of tests passing. The diff compared to
> v4 is relatively simple, so I don't think that would be an issue by
> itself,
Thanks! I don't see the patch attached. Would you mind sharing it?
> but it's another control version change.
Do you see the control version change as a concern?
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2026-08-29 03:03:49 | Re: remove_useless_joins vs. bug #19560 |
| Previous Message | Bharath Rupireddy | 2026-08-28 23:12:00 | Re: [PATCH] Release replication slot on error in SQL-callable slot functions |