Re: Remove toast_max_chunk_size from control file

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove toast_max_chunk_size from control file
Date: 2026-09-07 01:34:50
Message-ID: ap4UunPevJdqg9d1@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Sep 06, 2026 at 09:25:34PM -0400, Tom Lane wrote:
> EXTERN_TUPLES_PER_PAGE is a free variable here, and it's entirely
> possible that someone would wish to tweak it. So I disagree that
> it's safe to remove this value from pg_control.

Requoting my previous message that you did not include:

> There may be an argument about somebody enforcing a new
> TOAST_OID_MAX_CHUNK_SIZE or EXTERN_TUPLES_PER_PAGE manually, of
> course, but while we claim that tweaks are possible in heaptoast.h,

I've never seen anybody actually do that. So yes, I agree that if
somebody has the idea to change this value manually, the control file
value makes sense to keep. It's just that I doubt that anybody is
actually doing that. :)
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-09-07 01:43:33 Re: Remove toast_max_chunk_size from control file
Previous Message Tom Lane 2026-09-07 01:25:34 Re: Remove toast_max_chunk_size from control file