Re: problems with toast.* reloptions

I've committed everything but the last two patches. I've attached a
rebased patch set.

On Wed, Aug 19, 2026 at 04:16:40PM +0900, Michael Paquier wrote:
> The API contract in v13-0004 looks much better to me now. No more
> overwrites of the inputs. It's almost like you could add some const
> markers.

Done in v14.

> At the end of the day, get_effective_relopts() acts as a thin wrapper
> of extractRelOptions(), merging two existing code patterns and
> re-using the same pattern for the scoring. Perhaps "effective" is the
> term that troubles me here, while having merge_toast_reloptions().
> You need the merge_*() for the vacuum part, but I'm also wondering if
> this could not be reworked with less routines overall. I don't have a
> clean idea on top of my mind now, and that does not count as an
> objection. This gives an impression of being slightly
> overcomplicated.

I haven't thought of anything better.

> The test looks pretty nice here.

Thanks for reviewing!

--
nathan