Re: test_aio: Fix broken error recovery assertions in 001_aio

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jelte Fennema-Nio <me(at)jeltef(dot)nl>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: test_aio: Fix broken error recovery assertions in 001_aio
Date: 2026-08-19 23:18:02
Message-ID: aoY5qjW3HWvX59Xy@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 19, 2026 at 12:08:56PM +0200, Jelte Fennema-Nio wrote:
> The three error recovery checks in `test_handle()` used `qr/^|ok$/` to
> look for the `ok` marker column in psql's output. That is an alternation
> of `^` and `ok$`, and `^` matches every string, so the assertions passed
> no matter what psql printed.

Passing by..

Oops, /^|ok$/ with a '|' meaning OR in this context, or match all
strings. That's clearly broken, yes.

Will check later and fix. Thanks for the report.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2026-08-19 23:23:53 Re: Logical replication row filter loses unchanged toasted columns
Previous Message Peter Geoghegan 2026-08-19 22:59:21 GIN page deletion and page recycling bugs