Re: [PATCH] Fix compilation of nodeMergejoin.c with EXEC_MERGEJOINDEBUG

On Sun, Aug 16, 2026 at 03:27:43PM +0900, Tatsuya Kawata wrote:
> debugtup() is declared in access/printtup.h, but execdebug.h includes
> only executor/executor.h and nodes/print.h. The attached one-line patch
> adds it.
>
> As for back-patching, I think master alone is enough since this is
> debug-only code, but I don't have a strong opinion.

The oldest version of the tree I have around is v11, and if I enable
EXEC_MERGEJOINDEBUG I get the exact same failure. This means that
this has been unnoticed for at least 10 years.

So question time: Is this debugging code still relevant and wouldn't
it be better to just remove it? It looks pretty clear to me that
nobody is using this #define at all, or this failure would have been
noticed a long time ago.

Note that an all-time search of EXEC_MERGEJOINDEBUG on pgsql-hackers
and pgsql-bugs points only at this thread.
--
Michael