| From: | Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | [PATCH] Fix compilation of nodeMergejoin.c with EXEC_MERGEJOINDEBUG |
| Date: | 2026-08-16 06:27:43 |
| Message-ID: | CAHza6qevy6_D0Nr3SY=c7FG+pc7upZ0sBpc9hUMU1anckWdU=A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
nodeMergejoin.c does not compile when EXEC_MERGEJOINDEBUG is defined:
In file included from src/backend/executor/nodeMergejoin.c:96:
src/backend/executor/nodeMergejoin.c: In function 'ExecMergeTupleDumpOuter':
src/include/executor/execdebug.h:107:57: warning: implicit declaration of
function 'debugtup'; did you mean 'MJ_debugtup'?
[-Wimplicit-function-declaration]
107 | #define MJ_debugtup(slot)
debugtup(slot, NULL)
| ^~~~~~~~
src/backend/executor/nodeMergejoin.c:551:17: note: in expansion of macro
'MJ_debugtup'
551 | MJ_debugtup(outerSlot);
| ^~~~~~~~~~~
debugtup() is declared in access/printtup.h, but execdebug.h includes
only executor/executor.h and nodes/print.h. The attached one-line patch
adds it.
As for back-patching, I think master alone is enough since this is
debug-only code, but I don't have a strong opinion.
Regards,
Tatsuya Kawata
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-compilation-of-nodeMergejoin.c-with-EXEC_MERG.patch | application/octet-stream | 861 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-08-16 06:31:34 | Re: GiST wal_consistency_checking issue |
| Previous Message | Alexandre Felipe | 2026-08-16 06:14:48 | Re: Restructured Shared Buffer Hash Table |