Re: scary patch contest

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: scary patch contest
Date: 2026-08-25 18:31:21
Message-ID: ao3feQ-_v6mCR3dU@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 25, 2026 at 08:13:10PM +0200, Daniel Gustafsson wrote:
> > On 25 Aug 2026, at 18:48, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> > #2 has been cut back in scope enough that I don't think we would have accepted
> > the feature originally if it had been subject to those limitations, which IMHO
> > is a reasonable argument for a revert but also not conclusive.
>
>
> I don't think that is an argument for reverting, I think it's an argument for
> blocking progress by making perfect the enemy of good.
>
> > I'm pretty scared about all of #1-#3 having a long tail of bugs that we haven't
> > found yet, in pretty critical areas.
>
> I'll prepare a revert.

Uh, I am confused. We are now considering reverting these?

1. RI fast-path FK checks / batching (2da86c1ef9b, b7b27eb41a5,
2. REPACK / REPACK CONCURRENTLY (ac58465e061, 28d534e2ae0, Antonin
3. Online data checksums (f19c0eccae9, Daniel Gustafsson and Magnus

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2026-08-25 18:50:37 Re: scary patch contest
Previous Message Daniel Gustafsson 2026-08-25 18:13:10 Re: scary patch contest