Re: problems with toast.* reloptions

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Greg Burd <greg(at)burd(dot)me>
Cc: solai v <solai(dot)cdac(at)gmail(dot)com>, Nikita Malakhov <hukutoc(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: problems with toast.* reloptions
Date: 2026-08-12 17:17:22
Message-ID: anyqokNVrCsxt9Vp@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 11, 2026 at 04:43:19PM -0500, Nathan Bossart wrote:
> Here is a new patch set with an attempt at the above. The new 0005
> contains the log_autovacuum_min_duration default change along with an
> assertion that all TOAST storage parameters have unsettable defaults. 0006
> is just some prerequisite refactoring for 0007. And 0007 is the fix with
> the merge done based on the main reloption list instead of new arrays.

After sleeping on this, I realized that we can simplify things a bit by
using merge_toast_reloptions() for manual VACUUM, too. I've added a new
0007 for that. The autovacuum fix now lives in 0008.

--
nathan

Attachment Content-Type Size
v9-0001-Remove-extract_autovac_opts.patch text/plain 11.5 KB
v9-0002-Make-autovacuum_enabled-a-ternary-reloption.patch text/plain 3.6 KB
v9-0003-Add-an-unset-value-for-vacuum_index_cleanup.patch text/plain 3.5 KB
v9-0004-Simplify-autovacuum-s-TOAST-to-main-relation-relo.patch text/plain 3.8 KB
v9-0005-Give-TOAST-storage-parameters-unsettable-defaults.patch text/plain 5.0 KB
v9-0006-Move-the-StdRdOptions-parse-table-to-file-scope.patch text/plain 7.8 KB
v9-0007-Fix-VACUUM-s-handling-of-TOAST-storage-parameters.patch text/plain 13.0 KB
v9-0008-Fix-autovacuum-s-handling-of-TOAST-storage-parame.patch text/plain 12.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2026-08-12 17:26:04 Re: [PATCH]Fix pg_xact corruption from subtransaction abort after subcommit
Previous Message Nathan Bossart 2026-08-12 17:12:26 Re: Introduce psystem() to replace system()