| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Greg Burd <greg(at)burd(dot)me>, solai v <solai(dot)cdac(at)gmail(dot)com>, Nikita Malakhov <hukutoc(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: problems with toast.* reloptions |
| Date: | 2026-08-11 21:45:49 |
| Message-ID: | anuYDQ4SG7maSSq4@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 11, 2026 at 09:53:53AM -0500, Sami Imseih wrote:
> I looked these patches while looking at potential cases for injection point
> conditional strings [0], which could allow for better autovacuum testing,
> particularly for the case being discussed here.
Thanks for reviewing.
> 1/ Instead of setting toast_vacuum_params.* inside each branch, it reads
> cleaner to set toast_vacuum_params.* after params.* is done, and this
> way you only set toast_vacuum_params.*once. For example, in
> index_cleanup:
Done in v8 [0].
> 2/ A couple of comment tweaks in merge_autovac_opts()
I don't think these changes apply to v8, except for perhaps the "NB" one,
which I expanded a bit.
[0] https://postgr.es/m/anuXd35G8WLTUaBR%40nathan
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexandre Felipe | 2026-08-11 22:08:44 | Re: Restructured Shared Buffer Hash Table |
| Previous Message | Nathan Bossart | 2026-08-11 21:43:19 | Re: problems with toast.* reloptions |