| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql(at)j-davis(dot)com |
| Subject: | Re: CREATE INDEX vs. TOAST table stats |
| Date: | 2026-08-11 19:44:22 |
| Message-ID: | ant7ls0-vDPloJHX@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 11, 2026 at 02:25:10PM -0500, Sami Imseih wrote:
> One thing is CREATE INDEX, mentioned in the subject, never calls
> index_update_stats() on the toast relation, so the toast stats are not
> updated by it. This will only be called when the toast's own index is
> rebuilt, i.e. REINDEX, VACUUM FULL, CLUSTER, REPACK.
Sorry, I'm untangling a few different things in this area and got it mixed
up. I think you're right, and I think I also misstated the impact. But
IMHO the fix is still the way to go, for the two reasons I mentioned
upthread.
> +1 on backpatching to v18.
Thanks for reviewing.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2026-08-11 19:59:21 | Re: Bump soft open file limit (RLIMIT_NOFILE) to hard limit on startup |
| Previous Message | Alexandre Felipe | 2026-08-11 19:32:40 | Re: [PATCH] bufmgr: tighten LWLock:BufferMapping on InvalidateBuffer |