Re: Re-read subscription state after lock in AlterSubscription

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Re-read subscription state after lock in AlterSubscription
Date: 2026-08-04 05:55:12
Message-ID: anF+wLFJdW9sNcvh@bdtpg
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Mon, Jul 06, 2026 at 02:53:39PM +0000, Bertrand Drouvot wrote:
> Hi,
>
> On Mon, Jul 06, 2026 at 03:07:24PM +0530, Amit Kapila wrote:
>
> DROP SUBSCRIPTION however has its own dedicated code path and does not go through
> get_object_address(): 0003 adds the retry loop for it. And if DROP already uses
> the retry loop then ALTER should probably use it too (also done in 0003 and 0004).

Mandatory rebase attached.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v5-0001-Re-read-subscription-state-after-lock-in-AlterSub.patch text/x-diff 3.9 KB
v5-0002-Re-read-subscription-state-after-lock-in-DropSubs.patch text/x-diff 3.3 KB
v5-0003-Add-invalidation-based-retry-loop-for-Alter-Drop-.patch text/x-diff 8.7 KB
v5-0004-Add-invalidation-based-retry-loop-for-AlterPublic.patch text/x-diff 5.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2026-08-04 06:03:20 Re: Fix BUG #19586: money division overflow for INT64_MIN / -1
Previous Message Andrey Borodin 2026-08-04 05:44:53 Re: [PATCH] Fix vacuum_delay_point happening inside lock