| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Daniil Davydov <3danissimo(at)gmail(dot)com> |
| Subject: | Re: Allow a condition string in an injection point |
| Date: | 2026-08-03 11:16:57 |
| Message-ID: | anB4qcuFd9qQY-PS@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 24, 2026 at 12:58:36PM +0000, Bertrand Drouvot wrote:
> I think we should reject empty condition strings at attach time: when the string
> is empty, condition->str[0] == '\0' is true, so the injection point can never
> fire regardless of arg.
While looking at this patch, I'd like to have at least one valid test
using it. Could you propose one within the scope of this thread? An
autovacuum case has been proposed, at least, but perhaps we have
something simpler proposed recently where this facility could prove
useful?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2026-08-03 11:17:12 | POC: Unlocked path for GetSnapshotDataReuse |
| Previous Message | Michael Paquier | 2026-08-03 11:09:32 | Re: Return DSA area for hash table from GetNamedDSHash() |