| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoid unnecessary server restarts in the Kerberos TAP test |
| Date: | 2026-08-03 04:51:17 |
| Message-ID: | anAeRVIsS6AlD4zO@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 03, 2026 at 09:59:38AM +0530, Ayush Tiwari wrote:
> While reading src/test/kerberos/t/001_auth.pl I noticed it restarts the
> server after every configuration change, even though none of them needs a
> restart. gss_accept_delegation is a PGC_SIGHUP parameter, and pg_hba.conf
> and pg_ident.conf are re-read on SIGHUP, so a reload is sufficient in every
> case. The rest of the authentication suite already relies on this, via the
> reset_pg_hba() helper that reloads rather than restarts.
>
> The attached patch replaces the seven restarts with reloads. The test
> still passes here (142 tests) and is a little quicker, since it no longer
> bounces the postmaster seven times.
Wouldn't that be problematic for EXEC_BACKEND or WIN32, as the
configuration is passed down from a postmaster to the backends started
with their dedicated commands?
We have had quite a few discussions regarding the reload of ident and
hba rules when working on 004_file_inclusion.pl regarding that, FWIW,
and the limitations a reload involved in the scope of the TAP tests.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-08-03 04:52:01 | Re: Reduce memory overheads for storing a Memoize tuple |
| Previous Message | Ayush Tiwari | 2026-08-03 04:29:38 | Avoid unnecessary server restarts in the Kerberos TAP test |