| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Daniil Davydov <3danissimo(at)gmail(dot)com> |
| Subject: | Re: Allow a condition string in an injection point |
| Date: | 2026-08-14 06:16:24 |
| Message-ID: | an6yuHhq-gJ2jNao@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 13, 2026 at 04:53:29PM -0500, Sami Imseih wrote:
> Yeah, you're right, local vs shared injection points tests don't
> really make a difference
> here. With that said, just because shared points are the more common
> case, I kept
> those instead.
Okay, that works here. My previous point feels a bit moot due to
TestInjectionNoticeFunc, but that would be my fault.
> I do like the 051 test you mention and I think we should add a string
> to the "sync_slot" as well. This is good for demo.
> See attached 0002 for this.
>
> With that said, I think the stronger case for injection points string filters
> are tests in which we can't use set_local and we can do wait_for_event
> which is more robust that using regexp.
If others would like to be fancier, that could always happen later.
It does not change the fact that this stuff has merit in the long run.
Edited a couple of things, like comments, some ereport() vs elog().
And then applied both things.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | shveta malik | 2026-08-14 05:58:50 | Re: Support EXCEPT for TABLES IN SCHEMA publications |