| From: | Christoph Berg <myon(at)debian(dot)org> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-www(at)lists(dot)postgresql(dot)org, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Contributors <contributors(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Introduce contributor badges |
| Date: | 2026-07-29 12:51:36 |
| Message-ID: | amn3WJa9Z7-ApNx_@msg.df7cb.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
Re: To Magnus Hagander
> I'm attaching that as a separate commit for better review. It would
> get squashed before committing, of course.
>
> I believe that addresses the concerns from Brussels, or was there
> anything else?
To finally pick this up again (my fault for slacking): We've talked in
Vancouver and the remaining concern was that the image URLs were
user-configurable free text.
I have now cherry-picked the ImageBinaryField feature from pgeu-system
and image upload is now fully self-contained in the pgweb database.
Attached is v7 of the patch, before squashing:
v7-0001-Cherry-pick-ImageBinaryField-and-related-from-pge.patch
v7-0002-Rewind-uploaded-file-before-reading-in-ImageBinar.patch
ImageBinaryField and a follow-up fix in there that I'll submit to
pgeu-system after review
v7-0003-Introduce-contributor-badges.patch
The original patch
v7-0004-Add-dates-on-badgeholders-so-people-can-be-retire.patch
The retirement feature
v7-0005-Use-ImageBinaryField-for-the-badges.patch
The switch to ImageBinaryField
v8 is the same after squashing 0003..0005. (With a better commit
message.)
v7-0001-Cherry-pick-ImageBinaryField-and-related-from-pge.patch
v7-0002-Rewind-uploaded-file-before-reading-in-ImageBinar.patch
v8-0003-Introduce-contributor-badges.patch
Christoph
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Cherry-pick-ImageBinaryField-and-related-from-pge.patch | text/x-diff | 10.3 KB |
| v7-0002-Rewind-uploaded-file-before-reading-in-ImageBinar.patch | text/x-diff | 1.5 KB |
| v7-0003-Introduce-contributor-badges.patch | text/x-diff | 36.0 KB |
| v7-0004-Add-dates-on-badgeholders-so-people-can-be-retire.patch | text/x-diff | 17.5 KB |
| v7-0005-Use-ImageBinaryField-for-the-badges.patch | text/x-diff | 10.2 KB |
| v8-0003-Introduce-contributor-badges.patch | text/x-diff | 47.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 陈天舟 | 2026-07-30 10:25:06 | Wiki editor request |
| Previous Message | Christoph Berg | 2026-07-29 12:30:55 | Re: About updating the list of architectures supported by APT repositories |