Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, alvherre(at)alvh(dot)no-ip(dot)org, nagata(at)sraoss(dot)co(dot)jp, thomas(dot)munro(at)gmail(dot)com, m(dot)polyakova(at)postgrespro(dot)ru, pgsql-hackers(at)postgresql(dot)org, teodor(at)sigaev(dot)ru
Subject: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors
Date: 2022-04-03 08:20:05
Message-ID: alpine.DEB.2.22.394.2204030956500.2117840@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>> Or those three columns always, sum_lag sum_lag_2, min_lag max_lag,
>> skipped, retried retries?
>
> What about this? (a log line is not actually folded)
> interval_start num_transactions sum_latency sum_latency_2 min_latency max_latency
> failures serialization_failures deadlock_failures retried retries [ sum_lag sum_lag_2 min_lag max_lag [ skipped ] ]

My 0.02€:

I agree that it would be better to have a more deterministic
aggregated log format.

ISTM that it should skip failures and lags if no fancy options has been
selected, i.e.:

[ fails ... retries [ sum_lag ... [ skipped ] ] ?

Alterlatively, as the failure stuff is added to the format, maybe it could
be at the end:

[ sum_lag ... [ skipped [ fails ... retries ] ] ] ?

> failures:
> always 0 (if --max-tries is 1, the default)
> sum of serialization_failures and deadlock_failures (if --max-tries is not 1)
>
> serialization_failures and deadlock_failures:
> always 0 (if --max-tries is 1, the default)
> 0 or more (if --max-tries is not 1)
>
> retried and retries:
> always 0 (if --max-tries is 1, the default)
> 0 or more (if --max-tries is not 1)
>
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2022-04-03 08:22:39 Re: CLUSTER sort on abbreviated expressions is broken
Previous Message Tom Lane 2022-04-03 07:09:07 Re: Fix overflow in DecodeInterval