Re: psql - add SHOW_ALL_RESULTS option

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: 2022-03-26 15:55:27
Message-ID: alpine.DEB.2.22.394.2203261650010.3931183@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Peter,

>> As Tom said earlier, wasn't this fixed by 618c16707? If not, is there any
>> other discussion on the specifics of this issue? I'm not aware of one.

This answer is that I had kept psql's calls to PQerrorMessage which
reports errors from the connection, whereas it needed to change to
PQresultErrorMessage to benefit from the libpq improvement.

I made the added autocommit/on_error_rollback tests at the end really
focus on multi-statement queries (\;), as was more or less intended.

I updated the tap test.


Attachment Content-Type Size
psql-show-all-results-18.patch text/x-diff 52.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2022-03-26 16:01:17 Invalid comment in ParallelQueryMain
Previous Message Jonathan S. Katz 2022-03-26 15:10:55 PostgreSQL 15 Release Management Team (RMT) + Feature Freeze