| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, kawamoto(at)sraoss(dot)co(dot)jp, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Typo in pgbench messages. |
| Date: | 2022-02-25 12:07:46 |
| Message-ID: | alpine.DEB.2.22.394.2202251244220.2997974@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Daniel,
>> I think that the break of typographical rules is intentional to allow
>> such simplistic low-level stream handling through pipes or scripts. I'd
>> prefer that the format is not changed. Maybe a comment could be added
>> to explain the reason behind it.
>
> That doesn't sound like an overwhelmingly convincing argument to print
> some messages with 'X %' and others with 'X%'.
Indeed. The no-space % are for database loading progress and the final
report which I happen not to process through pipes and are more
user-facing interfaces/reports. The stream piping need applies more to
repeated lines such as those output by progress, which happen to avoid
percentages anyway so the questions does not arise.
So fine with me wrt having a more homogeneous report.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2022-02-25 12:43:48 | Re: Some optimisations for numeric division |
| Previous Message | Georgios | 2022-02-25 12:05:31 | Add LZ4 compression in pg_dump |