Re: psql - add SHOW_ALL_RESULTS option

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: 2021-07-22 09:00:41
Message-ID: alpine.DEB.2.22.394.2107221051140.25741@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Pavel,

>> The newly added PSQL_WATCH_PAGER feature which broke the patch does not
>> seem to be tested anywhere, this is tiring:-(
> Do you have any idea how this can be tested?

The TAP patch sent by Peter on this thread is a very good start.

> It requires some pager that doesn't use blocking reading, and you need
> to do remote control of this pager. So it requires a really especially
> written pager just for this purpose. It is solvable, but I am not sure
> if it is adequate to this patch.

Not really: The point would not be to test the pager itself (that's for
the people who develop the pager, not for psql), but just to test that the
pager is actually started or not started by psql depending on conditions
(eg pset pager…) and that it does *something* when started. See for
instance the simplistic script attached, the output of which
could be tested. Note that PSQL_PAGER is not tested at all either.
Basically "psql" is not tested, which is a pain when developing a non
trivial patch.


Attachment Content-Type Size text/x-perl 61 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Artur Zakirov 2021-07-22 09:04:07 Re: BUG #15293: Stored Procedure Triggered by Logical Replication is Unable to use Notification Events
Previous Message Ranier Vilela 2021-07-22 09:00:15 Re: ORDER BY pushdowns seem broken in postgres_fdw