Re: Using COPY FREEZE in pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Using COPY FREEZE in pgbench
Date: 2021-07-04 05:22:12
Message-ID: alpine.DEB.2.22.394.2107040718080.2359988@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Tatsuo-san,

> So overall gain by the patch is around 15%, whereas the last test before
> the commit was 14%. It seems the patch is still beneficial after the
> commit.

Yes, that's good!

I had a quick look again, and about the comment:

/*
* If partitioning is not enabled and server version is 14.0 or later, we
* can take account of freeze option of copy.
*/

I'd suggest instead the shorter:

/* use COPY with FREEZE on v14 and later without partioning */

Or maybe even to fully drop the comment, because the code is clear enough
and the doc already says it.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-07-04 05:43:53 Re: [bug?] Missed parallel safety checks, and wrong parallel safety
Previous Message Thomas Munro 2021-07-04 04:27:21 Re: A qsort template