| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |
| Date: | 2021-06-26 16:08:19 |
| Message-ID: | alpine.DEB.2.22.394.2106261713440.482873@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
>> However, if slurp_file fails it raises an exception and aborts the
>> whole TAP unexpectedly, which is pretty unclean. So I'd suggest to
>> keep the eval, as attached. I tested it by changing the file name so
>> that the slurp fails.
>
> Seem quite unnecessary. We haven't found that to be an issue elsewhere
> in the code where slurp_file is used. And in the present case we know
> the file exists because we got its name from list_files().
Fine with me!
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-26 18:20:25 | pgsql: Remove undesirable libpq dependency on stringinfo.c. |
| Previous Message | Andrew Dunstan | 2021-06-26 15:01:07 | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arne Roland | 2021-06-26 16:24:40 | Re: Rename of triggers for partitioned tables |
| Previous Message | Arne Roland | 2021-06-26 15:50:49 | Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path |