| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Version reporting in pgbench |
| Date: | 2021-06-18 21:18:45 |
| Message-ID: | alpine.DEB.2.22.394.2106182300170.3211875@pseudo |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Tom,
>> Why not move the printVersion call right after the connection is
>> created, at line 6374?
>
> I started with that, and one of the 001_pgbench_with_server.pl
> tests fell over --- it was expecting no stdout output before a
> "Perhaps you need to do initialization" failure. If you don't
> mind changing that,
Why would I mind?
> I agree that printing immediately after the connection is made is a bit
> less astonishing.
Ok, so let's just update the test? Attached a proposal with the version
moved.
Note that if no connections are available, then you do not get the
version, which may be a little bit strange. Attached v3 prints out the
local version in that case. Not sure whether it is worth the effort.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-version-banner-2.patch | text/x-diff | 2.5 KB |
| pgbench-version-banner-3.patch | text/x-diff | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-18 21:28:39 | Re: Version reporting in pgbench |
| Previous Message | Heikki Linnakangas | 2021-06-18 21:16:32 | Re: A few nuances about specifying the timeline with START_REPLICATION |