Re: pgbench failed when -f option contains a char '@'

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "Wang, Shenhao" <wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench failed when -f option contains a char '@'
Date: 2020-12-20 13:43:01
Message-ID: alpine.DEB.2.22.394.2012201436420.17354@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Tom,

>> I think we should just leave this as it is. The user can simply rename
>> the file.
>
> Yeah. The assumption when we defined the script-weight syntax was that
> there's no particular reason to use "@" in a script file name, and
> I don't see why that's a bad assumption.

The "parser" looks for the last @ in the argument, so the simple
workaround is to append "@1".

I suggest the attached doc update, or anything in better English.

--
Fabien.

Attachment Content-Type Size
pgbench-weight-doc-1.patch text/x-diff 684 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Markman 2020-12-20 14:16:12 how to find log
Previous Message Fabien COELHO 2020-12-20 13:31:57 Re: pgbench failed when -f option contains a char '@'