Re: backup manifests and contemporaneous buildfarm failures

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Mikael Kjellström <mikael(dot)kjellstrom(at)mksoft(dot)nu>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: backup manifests and contemporaneous buildfarm failures
Date: 2020-04-06 05:18:10
Message-ID: alpine.DEB.2.21.2004060714030.16227@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


>> Do I need to precede those with some recursive chmod commands? Perhaps
>> the client should refuse to run if there is still something left after
>> these.
> I think the latter would be a very good idea, just so that this sort of
> failure is less obscure. Not sure about whether a recursive chmod is
> really going to be worth the cycles. (On the other hand, the normal
> case should be that there's nothing there anyway, so maybe it's not
> going to be costly.)

Could it be a two-stage process to minimize cost but still be resilient?

if (-d $DIR) {
emit warning
rmtree again
if (-d $DIR)
emit error


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-04-06 05:26:48 Re: 2pc leaks fds
Previous Message Andres Freund 2020-04-06 05:03:32 SyncRepLock acquired exclusively in default configuration