From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, daniel(at)manitou-mail(dot)org, peter(dot)eisentraut(at)2ndquadrant(dot)com, iwata(dot)aya(at)jp(dot)fujitsu(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: psql - add SHOW_ALL_RESULTS option |
Date: | 2020-01-16 21:33:48 |
Message-ID: | alpine.DEB.2.21.2001162217370.18871@pseudo |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Tom,
>> This is one of the patches already marked as RFC (since September by
>> Alvaro). Anyone interested in actually pushing it, so that it does not
>> fall through to yet another commitfest?
>
> TBH, I think we'd be better off to reject it. This makes a nontrivial
> change in a very long-standing psql behavior, with AFAICS no way to
> get back the old semantics. (The thread title is completely misleading
> about that; there's no "option" in the patch as it stands.)
The thread title was not misleading, the initial version of the patch did
offer an option. Then I was said "the current behavior is stupid (which I
agree), let us change it to the sane behavior without option", then I'm
told the contrary. Sigh.
I still have the patch with the option, though.
> Sure, in a green field this behavior would likely be more sensible ...
> but that has to be weighed against the fact that it's behaved the way it
> does for a long time, and any existing scripts that are affected by that
> behavior have presumably deliberately chosen to use it.
I cannot imagine many people actually relying on the current insane
behavior.
> I can't imagine that changing this will make very many people happier.
> It seems much more likely that people who are affected will be unhappy.
>
> The compatibility issue could be resolved by putting in the option
> that I suppose was there at the beginning.
Indeed.
> But then we'd have to have a debate about which behavior would be
> default,
The patch was keeping current behavior as the default because people do
not like a change whatever.
> and there would still be the question of who would find this to
> be an improvement. If you're chaining together commands with \; then
> it's likely that you are happy with the way it behaves today.
> Certainly there's been no drumbeat of bug reports about it.
Why would there be bug report if this is a feature? :-)
The behavior has been irritating me for a long time. It is plain stupid to
be able to send queries but not see their results.
--
Fabien.
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2020-01-16 21:33:58 | Re: FETCH FIRST clause PERCENT option |
Previous Message | Tom Lane | 2020-01-16 21:24:42 | Re: making the backend's json parser work in frontend code |