Re: pgbench - allow to create partitioned tables

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench - allow to create partitioned tables
Date: 2020-01-03 12:07:33
Message-ID: alpine.DEB.2.21.2001031302110.3482@pseudo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Peter,

>>> The documentation and pgbench --help output that accompanied this patch
>>> claims that the argument to pgbench --partition-method is optional and
>>> defaults to "range", but that is not actually the case, as the
>>> implementation requires an argument. Could you please sort this out?
>> AFAICS, if the user omits this argument, then the default is range as
>> specified in docs. I tried by using something like 'pgbench.exe -i -s
>> 1 --partitions=2 postgres' and then run 'pgbench -S postgres'.
> Ah, the way I interpreted this is that the argument to --partition-method
> itself is optional.

Yep. Optionnal stuff would be in [], where () is used for choices.

Would the attached have improved your understanding? It is somehow more
consistent with other help lines.


Attachment Content-Type Size
pgbench-help-part-1.patch text/x-diff 757 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Suraj Kharage 2020-01-03 12:41:45 Re: backup manifests
Previous Message Fabien COELHO 2020-01-03 12:01:18 Re: pgbench - use pg logging capabilities