| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | btkimurayuzk <btkimurayuzk(at)oss(dot)nttdata(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, btendouan <btendouan(at)oss(dot)nttdata(dot)com>, "ibrar(dot)ahmad(at)gmail(dot)com:" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - extend initialization phase control |
| Date: | 2019-11-07 08:18:06 |
| Message-ID: | alpine.DEB.2.21.1911070914310.20647@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>> I think that it may break --no-vacuum, and I thought that there may be
>>> other option which remove things, eventually. Also, having a NO-OP looks
>>> ok to me.
>>
>> As far as I read the code, checkInitSteps() checks the initialization
>> steps that users specified. The initialization steps string that
>> "v" was replaced with blank character is not given to checkInitSteps().
>> So ISTM that dropping the handling of blank character from
>> checkInitSteps() doesn't break --no-vacuum.
>>
> This is a patch which does not allow space character in -I options .
I do not think that this is desirable. It would be a regression, and
allowing a no-op is not an issue in anyway.
--
Fabien Coelho - CRI, MINES ParisTech
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2019-11-07 08:20:07 | Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message. |
| Previous Message | Julien Rouhaud | 2019-11-07 08:12:11 | Re: Collation versioning |