Re: psql - improve test coverage from 41% to 88%

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql - improve test coverage from 41% to 88%
Date: 2019-09-12 06:25:50
Message-ID: alpine.DEB.2.21.1909120825030.19467@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On Wed, Sep 11, 2019 at 10:52:01PM +0200, Fabien COELHO wrote:
>> AFAICR this is because the coverage was not the same:-) Some backslash
>> commands just skip silently to the end of the line, so that intermediate
>> \commands on the same line are not recognized/processed the same, so I moved
>> everything on one line to avoid this.
> I see. So basically this tests for more code paths to ignore
> backslash commands and it improves the coverage of \elif. Applied
> after fixing two nits:
> - Indentation was incorrect.
> - Moved the \elif test closer to the existing one for the false
> branch (you can grep #2 to find it).

Ok. Rebased version added, with some minor changes to improve readability
(comments, variables).


Attachment Content-Type Size
psql-tap-4.patch text/x-diff 48.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-09-12 07:55:03 Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
Previous Message Michael Paquier 2019-09-12 06:12:57 Re: [HACKERS] [PATCH] pageinspect function to decode infomasks