| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade: Error out on too many command-line arguments |
| Date: | 2019-08-30 07:14:07 |
| Message-ID: | alpine.DEB.2.21.1908300905100.28828@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bonjour Michaël,
> I don't see why not. Perhaps this could be done for pgbench and
> oid2name as well?
This is for pgbench.
I did not found a TAP test in pg_upgrade, I do not think that it is worth
creating one for that purpose. The "test.sh" script does not seem
appropriate for this kind of coverage error test.
The TAP test for oid2name only includes basic checks, options and
arguments are not even tested, and there is no infra for actual testing,
eg starting a server… Improving that would be a much more significant
effort that the one line I added to pgbench existing TAP test.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-08-30 07:34:23 | Re: refactoring - share str2*int64 functions |
| Previous Message | Michael Paquier | 2019-08-30 06:59:05 | Re: pg_upgrade: Error out on too many command-line arguments |