| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: refactoring - share str2*int64 functions |
| Date: | 2019-08-01 14:48:35 |
| Message-ID: | alpine.DEB.2.21.1908011453570.2692@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> extern uint64 pg_strtouint64(const char *str, char **endptr, int base);
>>
>> called 3 times, always with base == 10. We have a similar name but a totally
>> different interface, so basically it would have to be replaced
>> by something like the first interface.
>
> My understanding on this one was to nuke the base argument and unify
> the interface with our own, faster routines:
> https://www.postgresql.org/message-id/20190716201838.rwrd7xzbrybq7dop%40alap3.anarazel.de
Ok, so there is an agreement on reworking the unsigned function. I missed
this bit.
So I'll set out to write and use "pg_strtou?int64", i.e. 2 functions, and
then possibly generalize to lower sizes, 32, 16, depending on what is
actually needed.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2019-08-01 15:19:35 | Re: Avoid full GIN index scan when possible |
| Previous Message | Dean Rasheed | 2019-08-01 14:42:35 | Re: Multivariate MCV list vs. statistics target |