Re: [PATCH] Implement uuid_version()

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Jose Luis Tallon <jltallon(at)adv-solutions(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Implement uuid_version()
Date: 2019-07-13 06:31:58
Message-ID: alpine.DEB.2.21.1907130816430.8895@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Jose,

> Got it, and done. Please find attached a v2 patch with the upgrade script
> included.

Patch v2 applies cleanly. Compiles cleanly (once running configure
--with-uuid=...). Local make check ok. Doc build ok.

There are no tests, I'd suggest to add some under sql & change expected if
possible which would return all possible values, including with calling
pg_random_uuid() which should return 4.

Documentation describes uuid_version(), should it not describe
uuid_version(namespace uuid)?

I'd suggest to add an example.

The extension update script seems ok, but ISTM that "uuid-ossp-1.1.sql"
should be replaced with an updated "uuid-ossp-1.2.sql".


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-07-13 07:53:45 Re: Comment fix of
Previous Message Thomas Munro 2019-07-13 06:29:16 Re: Allow an alias to be attached directly to a JOIN ... USING