Re: pgsql: Rework the pg_statistic_ext catalog

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Rework the pg_statistic_ext catalog
Date: 2019-06-16 17:45:45
Message-ID: alpine.DEB.2.21.1906161933240.21115@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


Hello Tom,

>> I see that Coelho's two bleeding-edge-clang animals are reporting that
>> failure too. Normally I'd just ignore those two;

And you'd be right.

>> they break pretty regularly. Maybe you're using an
>> almost-bleeding-edge clang?
>
> Oh --- I managed to reproduce that failure locally on RHEL6 (nothing
> bleeding-edge anywhere), but it went away after make-clean-and-rebuild.

> I'm suspicious that the underlying cause was failure to recompile
> something that knows the value of CATALOG_VERSION_NO.

Hmmm. My animals compile out of the source tree, not sure how this could
happen.

> This theory is insufficient to explain why Coelho's animals failed,
> though. Maybe it would, if you also posit a ccache screwup? But it's
> not obvious from their configurations that they're using ccache at all.

Indeed, no ccache. The compilers change often (well, once a week), I do
not want anything kept across compiler versions. The animals are really
testing the compilers as much as they are testing postgres.

However, there is an autoconf cache, but I do not see why it would have
such an effect.

So no clue.

--
Fabien.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-06-16 17:52:03 Re: pgsql: Rework the pg_statistic_ext catalog
Previous Message Tom Lane 2019-06-16 15:16:04 Re: pgsql: Rework the pg_statistic_ext catalog