Re: pg_dump multi VALUES INSERT

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump multi VALUES INSERT
Date: 2019-06-14 17:01:19
Message-ID: alpine.DEB.2.21.1906141845560.19957@lancre
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Alvaro,

>> Shouldn't the --rows-per-insert option also be available via pg_dumpall?
>> All the other options for switching between COPY and INSERT are
>> settable in pg_dumpall.
>
> Uh, yeah, absolutely.
>
> Surafel, are you in a position to provide a patch for that quickly?

End of the week, more time, easy enough and I should have seen the issue
while reviewing. Patch attached.

BTW, is the libpq hostaddr fix ok?

--
Fabien.

Attachment Content-Type Size
dumpall-missing-opt-1.patch text/x-diff 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jesper Pedersen 2019-06-14 17:19:31 Re: Index Skip Scan
Previous Message Li, Zheng 2019-06-14 16:35:21 Re: Converting NOT IN to anti-joins during planning