| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Why does pg_checksums -r not have a long option? |
| Date: | 2019-05-28 07:59:37 |
| Message-ID: | alpine.DEB.2.21.1905280952380.30082@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> |I have no problem with changing it to -r. -f seems a bit wrong to me,
>> |as it might read as a file. And in the future we might want to implement
>> |the ability to take full filename (with path), in which case it would
>> |make sense to use -f for that.
>
> You could also use a long option for that without a one-letter option,
> like --file-path or such, so reserving a one-letter option for a future,
> hypothetical use is not really a stopper in my opinion. In consequence,
> I think that that it is fine to just use -f/--filenode.
Yep. Also, the -f option could be overloaded by guessing whether is
associated argument is a number or a path…
> Any objections or better suggestions from other folks here?
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hubert Zhang | 2019-05-28 09:39:58 | Re: accounting for memory used for BufFile during hash joins |
| Previous Message | Antonin Houska | 2019-05-28 07:55:04 | Re: Remove page-read callback from XLogReaderState. |