Re: [PATCH v5] Show detailed table persistence in \dt+

From: Fabien COELHO <fabien(dot)coelho(at)mines-paristech(dot)fr>
To: David Fetter <david(at)fetter(dot)org>
Cc: Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH v5] Show detailed table persistence in \dt+
Date: 2019-04-28 17:26:55
Message-ID: alpine.DEB.2.21.1904281917330.29865@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello David,

>> Patch applies. There seems to be a compilation issue:
>> describe.c:5974:1: error: expected declaration or statement at end of
>> input
>> }
> This is in brown paper bag territory. Fixed.

I do not understand why you move both size and description out of the
verbose mode, it should be there only when under verbose?

> I've sent a separate patch extracted from the one you sent which adds
> stdin to our TAP testing infrastructure. I hope it lands so it'll be
> simpler to add these tests in a future version of the patch.

Why not. As I'm the one who wrote the modified function, probably I could
have thought of providing an input. I'm not sure it is worth a dedicated
submission, could go together with any commit that would use it.


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-04-28 18:22:09 Re: [PATCH v4] Add \warn to psql
Previous Message Alexander Korotkov 2019-04-28 17:14:59 Re: Improve search for missing parent downlinks in amcheck