Re: [PATCH v1] Show whether tables are logged in \dt+

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: David Fetter <david(at)fetter(dot)org>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH v1] Show whether tables are logged in \dt+
Date: 2019-04-24 08:29:41
Message-ID: alpine.DEB.2.21.1904240949080.27327@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello David,

>>> I noticed that there wasn't a bulk way to see table logged-ness in psql,
>>> so I made it part of \dt+.
>> Applies, compiles, works for me.
>> ISTM That temporary-ness is not shown either. Maybe the persistence column
>> should be shown as is?
> Temporariness added, but not raw.

Ok, it is better like this way.

>> Tests?
> Included, but they're not stable for temp tables. I'm a little stumped
> as to how to either stabilize them or test some other way.

Hmmm. First there is the username which appears, so there should be a
dedicated user for the test.

I'm unsure how to work around the temporary schema number, which is
undeterministic with parallel execution it. I'm afraid the only viable
approach is not to show temporary tables, too bad:-(

>> Doc?
> What further documentation does it need?

Indeed, there is no precise doc, so nothing to update :-)/:-(

Maybe you could consider adding a case for prior 9.1 version, something
... case c.relistemp then 'temporary' else 'permanent' end as ...


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2019-04-24 09:55:12 Re: bug in update tuple routing with foreign partitions
Previous Message Kyotaro HORIGUCHI 2019-04-24 08:13:54 Re: standby recovery fails (tablespace related) (tentative patch and discussion)