| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> | 
|---|---|
| To: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> | 
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz> | 
| Subject: | reorder pg_rewind control file sync | 
| Date: | 2019-03-23 05:18:27 | 
| Message-ID: | alpine.DEB.2.21.1903230606350.18811@lancre | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
Bonjour Michaël,
On Sat, 23 Mar 2019, Michael Paquier wrote:
> On Fri, Mar 22, 2019 at 03:18:26PM +0100, Fabien COELHO wrote:
>> Attached is a quick patch about "pg_rewind", so that the control file 
>> is updated after everything else is committed to disk.
>
> Could you start a new thread about that please?  This one has already 
> been used for too many things.
Here it is.
The attached patch reorders the cluster fsyncing and control file changes 
in "pg_rewind" so that the later is done after all data are committed to 
disk, so as to reflect the actual cluster status, similarly to what is 
done by "pg_checksums", per discussion in the thread about offline 
enabling of checksums:
https://www.postgresql.org/message-id/20181221201616.GD4974@nighthawk.caipicrew.dd-dns.de
-- 
Fabien.
| Attachment | Content-Type | Size | 
|---|---|---|
| rewind-fsync-1.patch | text/x-diff | 1.4 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2019-03-23 06:20:59 | Re: Removing \cset from pgbench | 
| Previous Message | Alvaro Herrera | 2019-03-23 04:20:48 | Re: Transaction commits VS Transaction commits (with parallel) VS query mean time |