Re: Offline enabling/disabling of data checksums

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>, Sergei Kornilov <sk(at)zsrv(dot)org>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Offline enabling/disabling of data checksums
Date: 2019-03-22 18:02:36
Message-ID: alpine.DEB.2.21.1903221859220.18811@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Christoph,

>> - pg_log(PG_PROGRESS, "syncing target data directory\n");
>> - syncTargetDirectory();
>
> Doesn't the control file still need syncing?

Indeed it does, and it is done in update_controlfile if the last argument
is true. Basically update_controlfile latest version always fsync the
control file, unless explicitely told not to do so. The options to do that
are really there only to speed up non regression tests.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-03-22 18:19:27 Re: Ordered Partitioned Table Scans
Previous Message Thibaut Madelaine 2019-03-22 17:36:19 Re: Problem with default partition pruning