| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Offline enabling/disabling of data checksums |
| Date: | 2019-03-18 06:07:27 |
| Message-ID: | alpine.DEB.2.21.1903180702470.2506@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bonjour Michaël,
> Here are my notes about the fixes:
Thanks for the fixes.
> - pg_resetwal got broken because the path to the control file was
> incorrect. Running tests of pg_upgrade or the TAP tests of
> pg_resetwal showed the failure.
Hmmm… I thought I had done that with "make check-world":-(
> - pg_rewind was issuing a flush of the control file even if --no-sync
> was used.
Indeed, I missed this one.
> - Nit: incorrect header order in controldata_utils.c. I have kept the
> backend-only includes grouped though.
I'll pay attention to that the next time.
Thanks for the push.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2019-03-18 06:08:00 | Re: pg_basebackup ignores the existing data directory permissions |
| Previous Message | Michael Paquier | 2019-03-18 06:05:59 | Re: Online verification of checksums |