Re: get_controlfile() can leak fds in the backend

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Joe Conway <mail(at)joeconway(dot)com>
Subject: Re: get_controlfile() can leak fds in the backend
Date: 2019-02-27 09:23:45
Message-ID: alpine.DEB.2.21.1902271015100.10851@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Bonjour Michaël,

> Thoughts?

None.

However, while at it, there is also the question of whether the control
file should be locked when updated, eg with flock(2) to avoid race
conditions between concurrent commands. ISTM that there is currently not
such thing in the code, but that it would be desirable.

--
Fabie.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-02-27 09:32:31 Re: get_controlfile() can leak fds in the backend
Previous Message leif 2019-02-27 09:14:40 Re: BUG #15589: Due to missing wal, restore ends prematurely and opens database for read/write