Re: CPU costs of random_zipfian in pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CPU costs of random_zipfian in pgbench
Date: 2019-02-22 16:17:40
Message-ID: alpine.DEB.2.21.1902221716430.4182@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


>>> I also noticed that i is int in this function, but n is int64. That
>>> seems like an oversight.
>
> Indeed, that is a bug!

Here is a v2 with hopefully better wording, comments and a fix for the bug
you pointed out.

--
Fabien.

Attachment Content-Type Size
pgbench-zipf-doc-2.patch text/x-diff 3.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2019-02-22 16:19:17 Re: Pluggable Storage - Andres's take
Previous Message Fabien COELHO 2019-02-22 16:10:02 Re: CPU costs of random_zipfian in pgbench