Re: CPU costs of random_zipfian in pgbench

From: Georgios Kokolatos <gkokolatos(at)pm(dot)me>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Fabien Coelho <postgresql(dot)org(at)coelho(dot)net>
Subject: Re: CPU costs of random_zipfian in pgbench
Date: 2019-03-13 08:55:10
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested

For whatever it is worth, the patch looks good to me.

A minor nitpick would be to use a verb in the part:

`cost when the parameter in (0, 1)`


`cost when the parameter's value is in (0, 1)` or similar.

Apart from that, I would suggest it that the patch could be moved to
Waiting for Author state.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-03-13 09:08:33 Re: Offline enabling/disabling of data checksums
Previous Message Kyotaro HORIGUCHI 2019-03-13 08:24:15 Re: Introduce timeout capability for ConditionVariableSleep