Re: fix psql \conninfo & \connect when using hostaddr

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: fix psql \conninfo & \connect when using hostaddr
Date: 2018-11-17 16:12:41
Message-ID: alpine.DEB.2.21.1811171703090.16105@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>> I'm working on improving the patch.
> Cool.

Here is the updated v2

- libpq internal function getHostaddr get a length,
and I added an assert about it.
- added a few braces on if/if/else/if/else/else
- added an UNKNOWN_HOST macro to hide "???"
- moved host_addr[] declaration earlier to avoid some braces
- I have not refactored psql connection message,
but finally agree with Pavel & you have a point.


Attachment Content-Type Size
libpq-conn-2.patch text/x-diff 11.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2018-11-17 16:13:58 Re: pg11.1 jit segv
Previous Message Fabien COELHO 2018-11-17 16:02:43 Re: fix psql \conninfo & \connect when using hostaddr