Re: Conflicting option checking in pg_restore

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Conflicting option checking in pg_restore
Date: 2018-10-29 06:11:35
Message-ID: alpine.DEB.2.21.1810290704490.5317@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hallå Daniel,

> an assertion?

v2 applies, compiles, both local & global make check are ok.

Its CF category could have been "bug fix" or "restructuring".

> [...] Perhaps, we don’t really test for all other potential
> misconfigurations of the options so I can go either way. It’s also a
> cheap enough operation. Do you think it should be a check like today or

Michaël suggests that there is no issue of external tool using the
internal function, so I'm fine with this version.

I have switched the patch to ready for committer.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2018-10-29 06:35:09 Re: why commutator doesn't work?
Previous Message Andrey Borodin 2018-10-29 05:59:37 Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line