Re: pgbench - add pseudo-random permutation function

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Hironobu SUZUKI <hironobu(at)interdb(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench - add pseudo-random permutation function
Date: 2018-10-25 06:21:27
Message-ID: alpine.DEB.2.21.1810250755090.26778@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


Hello Alvaro,

>> although not comment changes which break the logic of the algorithm
>> descriptions. I have not found how to tell pgindent to let comments
>> indentation alone.
>
> You can use /*----- for such comments.

Thanks for the hint. Here is an updated patch using this marker.

I noticed that some instances use a closing "*-----" sequence, but it does
not seem useful, so I left it out.

I have also tried to improve a few comments, and moved a declaration into
a loop because I did not like the pg-indented version much.

--
Fabien.

Attachment Content-Type Size
pgbench-prp-func-12.patch text/x-diff 18.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Samokhvalov 2018-10-25 06:57:18 Using old master as new replica after clean switchover
Previous Message Laurenz Albe 2018-10-25 06:13:53 Re: pg_stat_replication vs StandbyReplyMessage