Re: libpq stricter integer parsing

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: libpq stricter integer parsing
Date: 2018-09-07 15:13:17
Message-ID: alpine.DEB.2.21.1809071706210.26080@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Peter,

>> The timeout is set to 2, and the port directive is silently ignored.
>> However, URL parsing is stricter, eg on "port".
>>
>> The attached patch checks integer syntax errors and overflows, and report
>> errors.
>
> This looks useful and the patch looks reasonable, but it doesn't apply
> anymore. Can you send in an update?

Hmmm. It does apply on a test I just did right know...

Usually it does not apply with "git apply" if your MUA does not know that
MIME requires CR LF eol on text files, and that it is its responsability
to switch to something else if desired. Pg automatic patch checker does
not know about that so complains unduly. Some MUA send attachements which
violates MIME (text attachements with LF only eol), thus hidding the
issue.

Otherwise, the "patch" command should work?

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2018-09-07 15:14:41 Re: Removing useless \. at the end of copy in pgbench
Previous Message Peter Eisentraut 2018-09-07 15:05:21 Re: Hint to set owner for tablespace directory