| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Progress reporting for pg_verify_checksums |
| Date: | 2018-09-01 05:33:43 |
| Message-ID: | alpine.DEB.2.21.1809010728500.32764@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hallo Michael,
> my colleague Bernd Helmle recently added progress reporting to our
> pg_checksums application[1]. I have now forward ported this to
> pg_verify_checksums for the September commitfest, please see the
> attached patch.
It seems that the patch does not apply cleanly on master, neither with
"git apply" nor "patch". Could you rebase it?
> Here's the description:
>
> This optionally prints the progress of pg_verify_checksums via read
> kilobytes
MB? GB?
> to the terminal with the new command line argument -P.
>
> If -P was forgotten and pg_verify_checksums operates on a large cluster,
> the caller can send SIGUSR1 to pg_verify_checksums to turn progress
> status reporting on during runtime.
Hmmm. I cannot say I like the signal feature much. Would it make sense for
the progress to be on by default, and to have a quiet option instead?
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2018-09-01 05:40:40 | Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -r option) |
| Previous Message | Peter Eisentraut | 2018-09-01 05:28:37 | Re: file cloning in pg_upgrade and CREATE DATABASE |